From 088598eea38c66fd05a868dd2e910df7284f0648 Mon Sep 17 00:00:00 2001
From: Dax McDonald <dax@rancher.com>
Date: Mon, 13 Jan 2020 11:57:51 -0700
Subject: [PATCH] Update minimum rancher version in Istio charts

Due to changes in the UI of the Istio chart we need to add minimum
Rancher versions to ensure that the Istio chart will display its UI
elements correctly within Rancher.
---
 charts/rancher-istio/1.4.3/questions.yaml | 2 +-
 scripts/update-istio-release              | 9 ++++++---
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/charts/rancher-istio/1.4.3/questions.yaml b/charts/rancher-istio/1.4.3/questions.yaml
index 751f279..756de1b 100644
--- a/charts/rancher-istio/1.4.3/questions.yaml
+++ b/charts/rancher-istio/1.4.3/questions.yaml
@@ -1,3 +1,3 @@
 labels:
   rancher.istio.v1.4.3: 1.4.3
-rancher_min_version: 2.3.0-rc1
+rancher_min_version: 2.3.4-rc1
diff --git a/scripts/update-istio-release b/scripts/update-istio-release
index 12b9b35..84c87df 100755
--- a/scripts/update-istio-release
+++ b/scripts/update-istio-release
@@ -45,11 +45,14 @@ EOF
 done
 rm -r charts/rancher-istio/${1}/charts/istio-init
 
-# Add question.yaml
+# Add question.yaml, make need to update minimum rancher version
+RANCHER_MIN_VERSION="2.3.4-rc1"
+echo "Current rancher min version is set to $RANCHER_MIN_VERSION"
+
 cat > charts/rancher-istio/${1}/questions.yaml << EOF
 labels:
   rancher.istio.v${1}: ${1}
-rancher_min_version: 2.3.0-rc1
+rancher_min_version: $RANCHER_MIN_VERSION
 EOF
 
 # Replace the name of the chart
@@ -67,4 +70,4 @@ cat ./scripts/istio/istio-values.yaml > charts/rancher-istio/${1}/values.yaml
 cat ./scripts/istio/istio-service-rbac.yaml > charts/rancher-istio/${1}/templates/istio-service-rbac.yaml
 
 # Replace tag
-sed -i 's/tag: 1.4.2/tag: '"${1}"'/g' charts/rancher-istio/${1}/values.yaml
\ No newline at end of file
+sed -i 's/tag: 1.4.2/tag: '"${1}"'/g' charts/rancher-istio/${1}/values.yaml
-- 
GitLab